Archive

Archive for December, 2013

GPT Passback tags and validation errors

December 16th, 2013 Comments off

Google released new passback tags for GPT (DFP) a while back. While these tags appear to work, they don’t comply with W3C standards. E.g

<script src="//www.googletagservices.com/tag/js/gpt.js">
googletag.pubads().definePassback('/7146/adunit', [300, 250]).display();
</script>

It seems you can have either src or text between the tags, not both. It generates this error:

line 533 column 9 – Error: The text content of element script was not in the required format: Expected space, tab, newline, or slash but found g instead.

I’m unsure of a solution at the moment. I have raised this issue with our account manager, but I don’t expect any fixes anytime soon.

Categories: Uncategorized Tags: ,

Another day, another vBulletin code error

December 16th, 2013 No comments

It seems that vBulletin doesn’t test on PHP 5.4 or 5.5 these days. Either that or they’re happy to just suppress errors rather than actually fix them.

I upgraded my forum today to vBulletin 4.2.2 and noticed these errors on a search page:

Warning: Declaration of vBForum_Item_SocialGroupMessage::getLoadQuery() should be compatible with vB_Model::getLoadQuery($required_query = ”, $force_rebuild = false) in …./packages/vbforum/item/socialgroupmessage.php on line 261

Warning: Declaration of vBForum_Item_SocialGroupDiscussion::getLoadQuery() should be compatible with vB_Model::getLoadQuery($required_query = ”, $force_rebuild = false) in …./packages/vbforum/item/socialgroupdiscussion.php on line 337

Luckily a user on vbulletin.com support forum has a fix: http://www.vbulletin.com/forum/forum/vbulletin-4/vbulletin-4-questions-problems-and-troubleshooting/4000233-warning-declaration-of-vbforum_item_socialgroupmessage?p=4000793#post4000793

What annoys me is that vBulletin released this version a while ago, but are still distributing it with this code error.

Categories: Uncategorized Tags: ,